Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Exclude internal calls from WAF rate limiter #591

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

charles-marion
Copy link
Collaborator

@charles-marion charles-marion commented Oct 18, 2024

Issue #, if available:

Description of changes:
The internal calls sending chunks (LLM Response Streaming) to the end user were reaching the WAF throttling limit added in #581.

To prevent this, the change excludes the VPC IPs from the throttling limit.

Testing
Check WAF Metrics + requested large output from the model with streaming.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@charles-marion charles-marion merged commit b6a5d5a into aws-samples:main Oct 18, 2024
1 check passed
@charles-marion charles-marion deleted the bug_internal_waf branch October 18, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants